feat(interview-prep): Porting Rosetta problems - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 125 forks source link

feat(interview-prep): Porting Rosetta problems #265

Closed NitronR closed 6 years ago

NitronR commented 6 years ago

Description

Pre-Submission Checklist

[ ] Your pull request targets the dev branch.
[ ] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[ ] All new and existing tests pass the command npm test.
[ ] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[ ] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[ ] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX

scissorsneedfoodtoo commented 6 years ago

@NitronR, sorry for the delay in reviewing these. Will leave some suggestions as comments if I come across anything.

scissorsneedfoodtoo commented 6 years ago

Other than those arrays, LGTM! Just a few minor things here and there like lists that can be fixed up later.

NitronR commented 6 years ago

@scissorsneedfoodtoo Changes done.

scissorsneedfoodtoo commented 6 years ago

@NitronR, alright, thank you for making those changes so quickly! Everything LGTM.

There are still some earlier problems with arrays that need to be renamed, but that's something we can do later.