feat(challenges): add browser fallback challenge

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 124 forks source link

feat(challenges): add browser fallback challenge #267

Closed joshalling closed 6 years ago

joshalling commented 6 years ago

Description

This is what I came up with for a browser fallback challenge. It's not perfect, but I think it gets the job done. I am open to making updates so your feedback is appreciated.

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes freeCodeCamp/freeCodeCamp#17546

scissorsneedfoodtoo commented 6 years ago

@joshalling, thank you for your continued work on this issue. Your lesson looks good, I just have a couple of suggestions for the description I'll leave as notes.

scissorsneedfoodtoo commented 6 years ago

Another thing I noticed is the placement of the lesson in the CSS section. In my opinion it comes a bit too early. Since it mentions CSS variables and goes into some detail about them, I think it should really come after CSS variables are taught. A better place might be right after the "Attach a Fallback value to a CSS Variable" lesson. By that point the user has already learned about CSS variables, how to use them, set a fallback for them, and so on, so introducing the concept of a browser fallback for cases where the variables might not be supported won't be so jarring.

Anyway, let me know what you think!

joshalling commented 6 years ago

@scissorsneedfoodtoo It looks like Travis CI doesn't like the id I am assigning now. I'll look into this next week.

scissorsneedfoodtoo commented 6 years ago

@joshalling, just took a look and I think it's because you have the new challenge you made twice in a row, albeit with different ids. But just take your time! No need to rush.

joshalling commented 6 years ago

@scissorsneedfoodtoo Thanks for pointing me in the right direction. Got it to pass. I agree that it flows better in the location you suggested so I moved it and made the description updates you suggested..

scissorsneedfoodtoo commented 6 years ago

@joshalling, thank you for taking the time to make this challenge and being open to my suggestions. Everything LGTM! Looking forward to your next contribution :+1: :+1: