fix(challenges): remove race condition from react lifecycle challenge

ojeytonwilliams commented 6 years ago

Description

Previously it was possible for the tests to fail if the timeout in componentDidMount() was too small - less than approximately 500ms. This change sets the state and checks that the component has been correctly rendered synchronously. As a result the timeout can be changed without issue.

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes freeCodeCamp/freeCodeCamp#17988

scissorsneedfoodtoo commented 6 years ago

@ojeytonwilliams, sorry for the delay in reviewing this. Just checked it out and everything works great, even with a 0ms delay!

Congratulations on your first contribution to freeCodeCamp! Thank you for taking the time to fix this issue. We're all really looking forward to your next contribution :+1: :+1:

ojeytonwilliams commented 6 years ago

@scissorsneedfoodtoo No worries about the delay - reviewing things can't be an easy process! I'm just glad it worked in this case.

freeCodeCamp / curriculum