fix(challenges): removed duplicate css top property applied visual design - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 124 forks source link

fix(challenges): removed duplicate css top property applied visual design #275

Closed TomerPacific closed 6 years ago

TomerPacific commented 6 years ago

Description

There were two duplicate css top properties. As suggested, I removed the one with a fixed top setting.

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #205

TomerPacific commented 6 years ago

Anyone want to close this issue?

Nirajn2311 commented 6 years ago

@TomerPacific it takes time for people to go through older PRs before they reach the recent and don’t worry for me once it took 2 weeks before it got merged.

scissorsneedfoodtoo commented 6 years ago

@TomerPacific, sorry for the delay in reviewing this. Everything LGTM! Looking forward to your next contribution :+1: :+1:

Also, thank you for helping to QA this, @Nirajn2311