fix(challenges): add solution, test to project euler problems - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 124 forks source link

fix(challenges): add solution, test to project euler problems #284

Closed iambk closed 5 years ago

iambk commented 6 years ago

Description

This commit achieves the following: Add solution to problems: 21, 25, 29, 35, 55 Add/modify tests to problems: 5, 12, 14, 25, 55 Update description to problems: 2, 3, 4, 5, 6, 7, 8, 9, 11, 12, 14, 15, 16, 17, 55

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX

iambk commented 6 years ago

I had to close my previous PR #283 because it had multiple commits from my open PR #278 . So, I actually closed both of them and squashed all my commits into one and opened up this PR. Sorry for any inconvenience.

scissorsneedfoodtoo commented 5 years ago

@iambk, thank you very much for all of your hard work updating these problems. I'm taking a look now and everything seems good! I'll just leave some comments if I find anything that needs to be changed.

scissorsneedfoodtoo commented 5 years ago

That's all I was able to find! Two very minor things, one of which was probably there for months now. Please let me know if you need some help with updating your PR! It can be a bit confusing the first time.

Here's a summary just in case:

First, switch to your branch with git checkout fix/project-euler-tests.

After you make the changes and add the JSON file, just use git commit --amend to use the same commit message. No need to make a new commit message or update your current message.

Finally, you'll need to force push back to your branch with git push -f origin fix/project-euler-tests. Then we'll see the changes you made reflected here.

iambk commented 5 years ago

Thank you for the review @scissorsneedfoodtoo . I've pushed the proposed changes.

scissorsneedfoodtoo commented 5 years ago

:sparkles: :sparkles: :sparkles: Congratulations on your first contribution to freeCodeCamp! :sparkles: :sparkles: :sparkles:

Thank you for all of your hard work here, @iambk. We're all really looking forward to your next contribution.