fix(challenges): Rosetta Code test errors and formatting - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 124 forks source link

fix(challenges): Rosetta Code test errors and formatting #288

Closed scissorsneedfoodtoo closed 5 years ago

scissorsneedfoodtoo commented 6 years ago

Description

Made a number of formatting changes to the challenge descriptions, and updated a number of the tests which were failing. More detail in https://github.com/freeCodeCamp/curriculum/issues/277.

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #277

scissorsneedfoodtoo commented 6 years ago

@NitronR, would you mind taking a look at this since you're familiar with the Rosetta Code section? Please let me know what you think and if there's any changes that should be made.

NitronR commented 6 years ago

@scissorsneedfoodtoo Sure!! I will take a look.

scissorsneedfoodtoo commented 5 years ago

@NitronR, I removed the tests and results variables from the tails of the problems I edited. There are still one or two of the problems where I had to leave them in because the solutions were very complicated or visual.

Would you mind taking another look when you get a chance?

NitronR commented 5 years ago

@scissorsneedfoodtoo I took a look just now. LGTM!!

scissorsneedfoodtoo commented 5 years ago

@NitronR, thank you a lot for your help!

scissorsneedfoodtoo commented 5 years ago

Though it's my own PR, I'll go ahead and merge it since it was checked out by @NitronR.