Closed dougouverson closed 5 years ago
The only pace I explicitly edited file was on line 2487: https://github.com/freeCodeCamp/curriculum/pull/303/files#diff-a814213cd8bd54104c2f7b58cd36ce65L2487 The other edits must have taken place when running test.
:sparkles: :sparkles: :sparkles: Awesome! Congratulations on your first contribution to freeCodeCamp! :sparkles: :sparkles: :sparkles:
Thank you for submitting a PR for this, @dougouverson. Great catch here. Sorry again about all the trouble you went through with the local setup, but I'm glad it's sorted and you were able to improve this challenge.
Happy coding!
Thank you @scissorsneedfoodtoo I learned much. I look forward to submitting more PRs in the future. The community is great!
I noticed that change is not showing up on page. Is this a caching issue? I did clear browser cache - fyi.
@dougouverson, it will take some time to show up on the live site. Usually what happens is that we merge fixes for about a week or two before pushing them to production. I think we'll be doing that soon, so keep an eye out for your fix!
Thank you for explanation. I’m leaning the process: behavior that’s inherent in systems, and what’s left to human discretion. Thanks.
On Thu, Sep 6, 2018 at 7:46 PM Kristofer Koishigawa < notifications@github.com> wrote:
@dougouverson https://github.com/dougouverson, it will take some time to show up on the live site. Usually what happens is that we merge fixes for about a week or two before pushing them to production. I think we'll be doing that soon, so keep an eye out for your fix!
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/freeCodeCamp/curriculum/pull/303#issuecomment-419276460, or mute the thread https://github.com/notifications/unsubscribe-auth/AEcG3UtmtV8cADAT2L5LR0_WKNBdVTc0ks5uYbPsgaJpZM4WYJ2B .
-- Doug Ouverson (239) 249-2842
should have said elements and not tags
Description
Pre-Submission Checklist
dev
branch.fix/
,feature/
, ortranslate/
(e.g.fix/challenge-tests
)npm test
.npm run commit
to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commitsChecklist: