feat(interview-prep): Porting Rosetta problems - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 124 forks source link

feat(interview-prep): Porting Rosetta problems #309

Closed NitronR closed 5 years ago

NitronR commented 5 years ago

Description

Pre-Submission Checklist

[ ] Your pull request targets the dev branch.
[ ] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[ ] All new and existing tests pass the command npm test.
[ ] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[ ] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[ ] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX

NitronR commented 5 years ago

@scissorsneedfoodtoo Sorry for the delay. I have updated the descriptions. I will look into adding the image for the challenge mentioned by you.

NitronR commented 5 years ago

@scissorsneedfoodtoo I have added the image. Please check it and tell me if anything else is needed to be done.

scissorsneedfoodtoo commented 5 years ago

@NitronR, everything LGTM! Thank you for taking the time to make all these changes. Merging now :+1: :+1: