fix(challenges): commented output was wrong - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 124 forks source link

fix(challenges): commented output was wrong #313

Closed Nirajn2311 closed 5 years ago

Nirajn2311 commented 5 years ago

Description

In the challenge ES6: the comment in line 8 says that the function returns a NaN which is false and it has been changed to 6 which is the correct output.

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes freeCodeCamp/#18121

scissorsneedfoodtoo commented 5 years ago

@Nirajn2311, thank you for taking the time to improve this challenge. Everything LGTM!