fix(schema): change schema and unpack script to fix tests in main repo

scissorsneedfoodtoo commented 5 years ago

Description

Added an additional argument to the getChallenges function call in unpack.js to act as a flag for when the unpack script is running. Then modified the lodash omit array so that translations are included in the array when the test suite is running, but excluded from the array when the unpack script is running. Effectively this means that the translations are not included in the challenge block when going through the test suite, but included in the challenge block for the unpack script. Finally I removed the unnecessary releasedOn section in unpackedChallenge.js, and removed both releasedOn and translations from challengeSchema.js.

All of these changes should fix the tests over on the main fCC branch.

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Partially addresses #204

raisedadead commented 5 years ago

Just to confirm this will not need any changes over at the fCC main?

scissorsneedfoodtoo commented 5 years ago

No, nothing should need to be changed in main. I installed the latest npm package in the main staging branch, then modified the getChallenges.js file of the package like I did here, and ran the test suite. The tests seemed to pass fine!

freeCodeCamp / curriculum