Closed scissorsneedfoodtoo closed 5 years ago
Just to confirm this will not need any changes over at the fCC main?
No, nothing should need to be changed in main. I installed the latest npm package in the main staging branch, then modified the getChallenges.js file of the package like I did here, and ran the test suite. The tests seemed to pass fine!
Description
Added an additional argument to the getChallenges function call in unpack.js to act as a flag for when the unpack script is running. Then modified the lodash omit array so that translations are included in the array when the test suite is running, but excluded from the array when the unpack script is running. Effectively this means that the translations are not included in the challenge block when going through the test suite, but included in the challenge block for the unpack script. Finally I removed the unnecessary releasedOn section in unpackedChallenge.js, and removed both releasedOn and translations from challengeSchema.js.
All of these changes should fix the tests over on the main fCC branch.
Pre-Submission Checklist
dev
branch.fix/
,feature/
, ortranslate/
(e.g.fix/challenge-tests
)npm test
.npm run commit
to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commitsChecklist:
Partially addresses #204