freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor
Creative Commons Attribution Share Alike 4.0 International
81 stars 124 forks source link

Change description/tests of React: Add Inline Styles in React #321

Open nathanhannig opened 5 years ago

nathanhannig commented 5 years ago

Describe the bug

https://learn.freecodecamp.org/front-end-libraries/react/add-inline-styles-in-react

The challenge states to set the fontSize to 40, this isn't exactly a bug, but I feel the challenge can cause confusion because the previous challenge asks the user to set the fontSize as "72px" and then states it can be set using either including px or omitting it. After reading that statement, I would imagine it is up to the user to decide how they want to implement in future challenges. I would also imagine it would be best practice to include the unit measurement normally.

I suggest the description for the challenge be change to have "40px" set and to update tests to allow both methods of setting fontSize like the previous challenge does as well..

Previous challenege is https://learn.freecodecamp.org/front-end-libraries/react/introducing-inline-styles