search

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor
Creative Commons Attribution Share Alike 4.0 International
81 stars 124 forks source link

fix(challenges): improved tests for adding background/background-image #325

Open jonathan-grah opened 5 years ago

jonathan-grah commented 5 years ago

Using the background-image property instead of background should still pass the tests.

image

RandellDawson commented 5 years ago

So are you suggesting the challenge instructions should be updated to explain how to use both background and background-image properties? Maybe the instructions can be changed to reflect how both can be used to change the background image, where background-image can only specify the image and the the background property can specify other properties ( ) in the same line. If there are not already other challenges dealing with the other property value which it can set, the I think there would need to be an additional challenge added to deal with them.

Maybe instead of this lesson teaching about the background property and only specifying the image, the lesson should be about the background-image property and the tests should only pass if background-image property is used. I think this lesson could lead into a next lesson where the background property is discussed in more detail.