freeCodeCamp / forum-theme

Themes that we use on our forums
BSD 3-Clause "New" or "Revised" License
14 stars 27 forks source link

Update header implementation for upcoming Discourse changes #120

Closed davidtaylorhq closed 4 months ago

davidtaylorhq commented 4 months ago

Checklist:

Closes #116


Discourse will soon be dropping the 'widget' system for rendering its header. This commit switches the theme from the deprecated APIs to the their modern equivalents. As a nice side effect, this also fixes the layout issue of the 'visit the curriculum' button for anonymous users.

More information on the changes can be found at https://meta.discourse.org/t/296544

Before:

SCR-20240411-jvkg SCR-20240411-jvjh

After:

SCR-20240411-jukh SCR-20240411-jugs
ShaunSHamilton commented 4 months ago

Thank you for taking the time to update this. I might be incorrectly testing this, but this is what I see: image

image

The header button is still too far up (on Chrome)