search

freeCodeCamp / freeCodeCamp

freeCodeCamp.org's open-source codebase and curriculum. Learn to code for free.
https://contribute.freecodecamp.org
BSD 3-Clause "New" or "Revised" License
405.26k stars 38.01k forks source link

Map has missing challenges #11547

Closed Bouncey closed 7 years ago

Bouncey commented 8 years ago

Desktop view (chrome)

missingmap

@BerkeleyTrue

ghost commented 8 years ago

does this happen with other languages? is there code to default to english if there isn't a translation for some text?

I'd like to help fix this one if it's suitable for beginners

ghost commented 8 years ago

Issue also occurs with english on staging and does NOT occur on master including with Spanish (might be due to browser cache? can anyone else reproduce the bug with english on staging?):

screenshot

I'd like to work on this issue - any help would be appreciated

ghost commented 8 years ago

okay the text reappears if I set those to isBeta: false - those four are set to isBeta: true. something is wrong with how beta challenges are rendered.

ghost commented 8 years ago

These two commits from https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10654 are suspect as that is the last change in master apparently but I'm going to bed. Will figure out why beta challenges are not displaying tomorrow.

https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10654/commits/26875725db41bb084d7fdf5ca1bb52b2ad2728a0

https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10654/commits/a4f1722c29b7ad68bb959ce7eba5b041ad01a7e3

ghost commented 8 years ago

here is the branch I'm using working on this. I also found a typo in utils.js

https://github.com/ashleypt/FreeCodeCamp/tree/fix/11547

ghost commented 8 years ago

Some of the Challenges being rendered in Challenge.jsx have undefined titles. These are not the only ones but for some reason they are the only ones with blank bullets. Here are the non-blank dashedNames of the challenges with this problem (if !title) console.log dashedName:

For now I am going to solve this problem by returning null if the title is undefined. In the future we need to find out WHY these titles are coming across as undefined

create-a-javascript-slot-machine
bundle.js:133062 add-your-javascript-slot-machine-slots
bundle.js:133062 bring-your-javascript-slot-machine-to-life
bundle.js:133062 give-your-javascript-slot-machine-some-stylish-images
bundle.js:133062 slice-and-splice
bundle.js:133062 learn-sass-challenges
bundle.js:133062 learn-react-challenges
bundle.js:133062 learn-d3-challenges
bundle.js:133062 learn-accessibility-challenges
bundle.js:133062 learn-agile-challenges
bundle.js:133062 learn-computer-science-challenges
bundle.js:133062 learn-data-visualization-challenges
bundle.js:133062 learn-embedded-and-internet-of-things-challenges
bundle.js:133062 learn-game-development-challenges
bundle.js:133062 learn-gamification-challenges
bundle.js:133062 learn-machine-learning-challenges
bundle.js:133062 learn-math-for-programmers-challenges
bundle.js:133062 learn-mobile-javascript-development-challenges
bundle.js:133062 learn-devops-challenges
bundle.js:133062 learn-software-engineering-principles-challenges
bundle.js:133062 learn-statistics-challenges
bundle.js:133062 learn-tools-challenges
bundle.js:133062 learn-user-experience-design-challenges
bundle.js:133062 learn-visual-design-challenges
raisedadead commented 8 years ago

@ashleypt apologies for the delay in responding. You may refer to https://github.com/FreeCodeCamp/FreeCodeCamp/pull/11575#issuecomment-259115693

raisedadead commented 8 years ago

does this happen with other languages?

I am guessing yes, and as you have already investigated for english too.

is there code to default to english if there isn't a translation for some text?

Nope. And there is an open issue that is to be addressed. Refer #11545

These two commits from #10654 are suspect as that is the last change in master apparently

Please refer code from the staging branch, that's what we are aiming, NOT the master branch

raisedadead commented 8 years ago

@Bouncey would like to guide @ashleypt further? Considering you have worked on the notification message with an open PR?

BerkeleyTrue commented 8 years ago

I'm unable to replicate.

@raisedadead Are you seeing the same? settings___free_code_camp

raisedadead commented 8 years ago

@BerkeleyTrue Yes, I can reproduce this is the latest staging for me:

image

BerkeleyTrue commented 8 years ago

So what is different between our setups?

raisedadead commented 8 years ago

Strange, IDK to be honest, apart from the fact that I cleared the db completely, and seeded freshly.

Bouncey commented 8 years ago

All the learn-* challenges are referenced in #9349, and are ok.

is there code to default to english if there isn't a translation for some text?

The challenges are all in english, it is only when there is a translation that the challenge changes. See here.

@ashleypt Thank you for all your work, and I am sorry for my delay in offering help with this

@BerkeleyTrue Do we want the slot machine & slice and splice challenges on the map? If I edit the seed files to set isBeta to false, the challenge renders normally. I haven't got my head around filterComingSoonBetaFromEntities yet, but I would guess it is in that area

ghost commented 8 years ago

yeah you need to do this on the staging db to see it.

On Wed, Nov 9, 2016 at 3:58 AM Mrugesh Mohapatra notifications@github.com wrote:

Strange, IDK to be honest, apart from the fact that I cleared the db completely.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FreeCodeCamp/FreeCodeCamp/issues/11547#issuecomment-259242276, or mute the thread https://github.com/notifications/unsubscribe-auth/AOKKP6zC0iLIzyj4wZNVKT_fAy6LzwjTks5q8NR_gaJpZM4Kqhbl .

BerkeleyTrue commented 8 years ago

Do we want the slot machine & slice and splice challenges on the map?

@Bouncey in dev all challenges render.

ghost commented 8 years ago

@BerkeleyTrue the bug probably doesn't occur in dev mode. marking those four challenges as isBeta: false also fixes it

BerkeleyTrue commented 8 years ago

the bug probably doesn't occur in dev mode.

What mode are you in?

marking those four challenges as isBeta: false also fixes it

It is an indication of where the problem may lie but it is does not fix the issue.

ghost commented 8 years ago

@BerkeleyTrue the default one. I don't change it... maybe that is dev mode?

doesnt fix issue

yeah I know... what could be causing this? I'm not really familiar with redux though ive played a bit with react

BerkeleyTrue commented 8 years ago

@ashleypt I'm unable to reproduce so I could not investigate

If you are able to reproduce, could you investigate? Until we find the actual cause a PR cannot be submitted.

ghost commented 8 years ago

@BerkeleyTrue sure, might take some time as im unfamiliar with the code base but I'll eventually get to the bottom of these pesky blank bullets and undefined titles :)

@Bouncey any tips or places to start in the code? I think I should watch a video on redux first...

Bouncey commented 8 years ago

@ashleypt this is not a redux issue, i think this is about how the challenges are filtered, look around here

If you want to see where that function is used, use the search in this repo to see where it shows up. I'd love to help more but I have to sleep .

Happy coding!

BerkeleyTrue commented 8 years ago

@QuincyLarson is also unable to reproduce

Bouncey commented 8 years ago

What are the differences in ENV?

I have recently deleted node_modules and bower_components and did a fresh install of both.

browser: chrome@latest
OS: Ubuntu 16.04
node: v6.9.1
npm: v3.10.8
mongod:
  db version v3.2.9
  git version: 22ec9e93b40c85fc7cae7d56e7d6a02fd811088c
ghost commented 8 years ago

Yes, I also did fresh runs each time with git clean -fxd.

edit:

OS Linux Mint 18 64 bit (Ubuntu 16.04)
node 7.0.0
npm 4.0.2
mongod 3.2.10
mridulnagpal commented 7 years ago

Can I help with this Issue?

ghost commented 7 years ago

yes im a bit overwhelmed right now. feel free to take over

On Sun, Nov 20, 2016 at 2:09 AM Mridul Nagpal notifications@github.com wrote:

Can I help with this Issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FreeCodeCamp/FreeCodeCamp/issues/11547#issuecomment-261729675, or mute the thread https://github.com/notifications/unsubscribe-auth/AOKKPyPcNZE6F_JY8bX1W5l4jPEWwPn6ks5q_ztWgaJpZM4Kqhbl .

mridulnagpal commented 7 years ago

@ashleypt Could you please give me a little background of the problem I couldn't make it out from the comments please.

ghost commented 7 years ago

some challenges marked isBeta, plus some not are passed with a blank title prop in the jsx. they mention a few related functions here but my kb batteries are out so i can't type much now (using mouse lol)

On Sun, Nov 20, 2016 at 9:22 AM Mridul Nagpal notifications@github.com wrote:

@ashleypt https://github.com/ashleypt Could you please give me a little background of the problem I couldn't make it out from the comments please.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FreeCodeCamp/FreeCodeCamp/issues/11547#issuecomment-261751425, or mute the thread https://github.com/notifications/unsubscribe-auth/AOKKPzvoKdbzeg5RnyyuGKYq7Gh-2Hcuks5q_6C5gaJpZM4Kqhbl .

raisedadead commented 7 years ago

Closing, can reproduce any longer, thanks @ashleypt and others for your TA on this.