search

freeCodeCamp / freeCodeCamp

freeCodeCamp.org's open-source codebase and curriculum. Learn to code for free.
http://contribute.freecodecamp.org/intro
BSD 3-Clause "New" or "Revised" License
400.86k stars 37.02k forks source link

Unable to check account closed & Missing user story #15222

Closed jaylane closed 7 years ago

jaylane commented 7 years ago

Challenge Use the Twitchtv JSON API has an issue. User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36. Please describe how to reproduce this issue, and include links to screenshots if possible.

I'm working on this project now and since it is suggested to use the third party api in lieu of registering for a twitch.tv api key, I don't think one of the user stories works now. The json response for one of the suggested closed account users (comster404) is as follows:

{"stream":null,"_links":{"self":"https://api.twitch.tv/kraken/streams/comster404","channel":"https://api.twitch.tv/kraken/channels/comster404"}}

this is the same response as an active offline account, so I don't see a way to distinguish between the two.

Another minor issue is that the video shows a bonus user story to search for users via text input which isn't shown in the current project objective list.

Fubinator commented 7 years ago

I think that is intended behaviour. You can call the "https://wind-bow.glitch.me/twitch-api/channels/" endpoint to see if a channel still exists. If it does not exist the response's status code is 422. That would be a way to distinguish whether the channel does not exist or is just offline.

raisedadead commented 7 years ago

Sorry to get back late on this, although this was reported earlier. I am closing this in favor of #15321