Motivational quotes might be confusing

[naomi-lgbt]

Carrying on from #46429:

Some of the compliments in our quotes object, such as They're in another castle, may not make sense to campers.

Some of these are pop-culture references, like "Legen - wait for it - dary!", and "Moon Prism Power!". As someone who is familiar with those two particular phrases, seeing them pop up in my learning journey was a nice treat. However, campers who are not familiar with the references might not understand the meaning here.

Do we want to go through and clean up the ones that don't directly compliment the camper?

Original Conversation: https://github.com/freeCodeCamp/freeCodeCamp/pull/46429#issuecomment-1581267853

[moT01]

I vote to leave them. I didn't get some of them - but the ones I did, were nice to see.

[bbsmooth]

Ya, I'm fine with leaving them. My main concern is that we should also make it clear to screen reader users that they have passed the step by unhiding the check mark icon from them and giving it an accessible name like "Step completed". Then they would hear "Step completed", and then the quote.

[ahmaxed]

Thank you for creating a separate issue to address the quotes. How about keeping the success message. And having the quote in the row of its own so there is no confusion? In future iterations we could make the success message shorted and merge both if necessary.

[ahmaxed]

How about this for the success state so there is no confusion.

[CBID2]

So…is this issue solved or???

[ahmaxed]

Yes, the related pr will be modified accordingly.