freeCodeCamp / freeCodeCamp

freeCodeCamp.org's open-source codebase and curriculum. Learn to code for free.
http://contribute.freecodecamp.org/
BSD 3-Clause "New" or "Revised" License
390.8k stars 35.83k forks source link

Playwright doesn't test mobile #52198

Open moT01 opened 7 months ago

moT01 commented 7 months ago

Describe the Issue

While reviewing playwright PR's, I kept getting failures locally, but everything was passing in the CI. After a little digging with Oliver, we found that the mobile chrome and mobile safari tests are running locally (if they're not turned off), but not in CI. Seems like we should probably add one or both of those mobile browsers to CI. Note that many tests will likely fail and need updating if we do. Perhaps we didn't add those for a reason, not sure.

Expected behavior

To have mobile tests

First Steps

While we discuss enabling the mobile tests in our CI, PRs would be welcomed to resolve the following failures in mobile testing:

### Failing Spec Files
- [x] `action-row.spec.ts` - #52446
- [x] `desktop-layout-component.spec.ts` - #52439, #52934
- [x] `editor-tabs.spec.ts` - #52454
- [x] `editor.spec.ts` - #52518
- [ ] `hotkeys.spec.ts`
- [x] `landing.spec.ts` - #52474
- [ ] `lower-jaw.spec.ts`
- [x] `notes.spec.ts` - #52475
- [x] `preview.spec.ts` - #52519
- [x] `progress-bar.spec.ts` - #52520
- [ ] `reset-modal.spec.ts`
- [x] `shortcuts-modal.spec.ts` - #52480
- [x] `tool-panel.spec.ts` - #52479
rahulsuresh-git commented 6 months ago

@moT01 I'd like to take a look at this issue and work towards resolving the root cause for the failures.

naomi-lgbt commented 6 months ago

Linked issues closed to be tracked here.

rahulsuresh-git commented 6 months ago

@huyenltnguyen @naomi-lgbt We can remove video-player.spec.ts and multifile-editor.spec.ts from the failing specs. It was a false positive. They seem to work fine on mobile.