freeCodeCamp / freeCodeCamp

freeCodeCamp.org's open-source codebase and curriculum. Learn to code for free.
https://contribute.freecodecamp.org
BSD 3-Clause "New" or "Revised" License
404.56k stars 37.91k forks source link

Incorrect link in Build A Tribute Page project #52750

Closed igorgetmeabrain closed 10 months ago

igorgetmeabrain commented 10 months ago

Describe the Issue

++Objective: Build an app that is functionally similar to https://personal-portfolio.freecodecamp.rocks/. Do not copy this demo project.

The link above should be: https://tribute-page.freecodecamp.rocks/

Affected Page

https://www.freecodecamp.org/learn/2022/responsive-web-design/build-a-tribute-page-project/build-a-tribute-page

Your code


N/A

Expected behavior

The link to the demo project should link to the demo Tribute Page but links instead to the demo Portfolio Webpage.

Screenshots

No response

System

Additional context

No response

huyenltnguyen commented 10 months ago

@igorgetmeabrain Thanks for reporting the issue.

We should also update the text to remove the ++ at the start of the sentence.


This issue is open to first-time code contributors to this repository. The file that you should be updating is https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/14-responsive-web-design-22/build-a-tribute-page-project/build-a-tribute-page.md.

Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or our forum if you need help contributing; our moderators will guide you through this.

Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first.

Happy contributing.

WOLFRIEND commented 10 months ago

@huyenltnguyen

Hi! I've created a pull-request for this issue: https://github.com/freeCodeCamp/freeCodeCamp/pull/52764. The only thing that I am worrying about, is tests. Although it's really tiny pull-request and nothing should break, I've tried to run tests just for my interest. But even on a new forked repository without any changes, I have one test fail (see screenshot).

image

I'm sure this has nothing to do with my pull-request, given that this error appears even without any changes. But, for the future, maybe you can tell me if I’m doing something wrong? Or is the problem in the tests?

huyenltnguyen commented 10 months ago

@WOLFRIEND That looks like a flaky test. Please help open a new issue for it.