search

freeCodeCamp / league-for-good

An open source sports league management tool
BSD 3-Clause "New" or "Revised" License
163 stars 106 forks source link

MaterialUI out of date? #129

Open domwakeling opened 5 years ago

domwakeling commented 5 years ago

Watching the (client) console, it's apparent that there is a props error:

warning.js?2f3c:33 Warning: Failed prop type: Invalid prop `nestedItems[0]` of type `array` supplied to `ListItem`, expected a single ReactElement.

I'm 99% certain (heck, I'm certain) that this is being thrown from nested lists in the 'Archived Leagues' menu item, introduced in PR #103. I'm not sure why it's throwing an error, since the docs for MaterialUI v0.20.0 state that nestedItems should be passed as an array.

However, this also raises the point that at present we're using MUI v0.20.0 whereas the current release is v4.0.1 (and it looks as though v4.0.2 has literally been pushed to npm in the last couple of hours).

So, question: is there an appetite to update to a more recent version of MUI (query whether that would be v4.0.x or the final, presumably stable, v3.9.0) or is it better to write the missing parts of the app on the older MUI and leave the update to later?

It looks as though there have been large changes in MUI, so - for instance - this nested list issue goes away because the way that nested menu items are dealt with is totally different

Happy to look at the change ...

paulywill commented 5 years ago

Are you able to test locally with the latest version of Material UI?

I'm always with the mindset that to keep a project fresh and active that it must have the latest versions of dependencies.

domwakeling commented 5 years ago

OK, I'll try to get a local version working on v4.0.x

domwakeling commented 5 years ago

So turns out (not entirely surprisingly) that a large part of the API for Material-UI has been re-written; working on it ...

domwakeling commented 5 years ago

Quick update, still working on this intermittently - not forgotten!