Refactor CreateLeagueButton (crashing error)

domwakeling commented 6 years ago

On initial fork/clone of the repo, CreateLeagueButton.js caused crashing errors

import calls referred to the file using .jsx extension
references to props not recognised in running app

This commit

changes file extension to .jsx
refactors CreateLeagueIcon into its own file
rewrites both CreateLeagueButton and CreateLeagueIcon as ES6 classes, fixing the props issue

The README is also extended to

provide additional information on setting up Google Sign-In; and
specify the typical MONGO_URI for an instance running on the localhost

Not sure whether this pull request is strictly in line with the contributing guidelines ...

makkoli commented 6 years ago

@domwakeling Hey, the way you did the pull request is good. I just have a couple of comments on the files you changed. If you are making components that don't have any state, just make them stateless components. https://toddmotto.com/stateless-react-components/ Thanks bud.

domwakeling commented 6 years ago

CreateLeagueButton & CreateLeagueIcon re-written as stateless components

freeCodeCamp / league-for-good

Refactor CreateLeagueButton (crashing error) #95