refactor(unit tests): DRY up the unit tests for invalid community events - Githubissues

freeCodeCamp / open-api

freeCodeCamp's open-api Intiative

BSD 3-Clause "New" or "Revised" License

89 stars 28 forks source link

refactor(unit tests): DRY up the unit tests for invalid community events #197

Closed utsab closed 5 years ago

utsab commented 5 years ago

This is a fix for #188. We're looking for feedback on this refactor to DRY up the unit tests. Please let us know if we are going in the right direction. Thank you.

ojongerius commented 5 years ago

This will need f32d0b79d6a5f21472accda68e01bfe13b70ac1f to go green

ojongerius commented 5 years ago

@utsab could you please merge staging or cherry-pick f32d0b79d6a5f21472accda68e01bfe13b70ac1f?

ValeraS commented 5 years ago

@ojongerius close/open PR to update config in Travis CI

ojongerius commented 5 years ago

@ValeraS that commit went in via https://github.com/freeCodeCamp/open-api/pull/199.

ValeraS commented 5 years ago

@ojongerius It doesn't matter

ojongerius commented 5 years ago

@ValeraS I'm not sure what you mean, could please elaborate?

ValeraS commented 5 years ago

~~@ojongerius I see, You do not merge it yet.~~

ValeraS commented 5 years ago

@ojongerius If close/open PR Travis CI will start a new build and take for this build config from the master branch.

Restart build in Travis CI UI does not update config.

ojongerius commented 5 years ago

@ValeraS aha! Nice trick 👍

ValeraS commented 5 years ago

@ojongerius After updating the configuration or if the cofig is up to date, you can simply restart the build in Travis itself, if you need to. No need to close/open PR.