search

freeCodeCamp / pantry-for-good

An open source food bank logistics and inventory management tool
Other
395 stars 189 forks source link

Add s-alert notifications #358

Closed DavOnGit closed 6 years ago

DavOnGit commented 6 years ago

Notify on submitting form field with errors and on settings saved succesfully. It uses a redux middleware that can be very flexible, all notifications logic is in one file.

This PR resolves #154

kenjiO commented 6 years ago

This looks really nice. There is one minor change I think will make it look better. The way the alert displays now makes it not stand out from the rest of the form. screen shot 2018-01-30 at 9 30 13 am

I tried it with <Alert stack={{limit: 3}} position={'top'} html={true} timeout={5000} effect={'flip'}/> and it is a lot more noticable to me. Can you do it this way instead?

screen shot 2018-01-30 at 9 51 53 am

DavOnGit commented 6 years ago

All done @kenjiO You should see ...position={'top'}, offset={0}... props in Application.js file.