search

freeCodeCamp / pantry-for-good

An open source food bank logistics and inventory management tool
Other
395 stars 189 forks source link

Add unit tests for Media Helpers and Notification Sender files #399

Closed tsukimi2 closed 6 years ago

tsukimi2 commented 6 years ago

(1) Added unit tests for server/lib/media-helpers.js and server/lib/notification-sender.js, (2) refactored async-await usage in functions searchUserAndSetNotification and searchVolunteerAndSetNotification in notificaiton-sender.js to facilitate unit testing, and (3) added function getAppRoot in server/tests/helpers.js

tsukimi2 commented 6 years ago

Committed the suggested changes. However, I just did git commit and git push -u origin instead of git commit -amend git push --force

Is the amendment of the pull request still going to work?

jspaine commented 6 years ago

Thanks!

Yeah that's fine, I'll squash them into one commit and merge it.