search

freeCodeCamp / publish

> Content backend platform for /news
https://publish.freecodecamp.org
BSD 3-Clause "New" or "Revised" License
10 stars 9 forks source link

fix: editorial team feedback changes part 1 #410

Closed Nirajn2311 closed 5 months ago

Nirajn2311 commented 5 months ago

Checklist:

Closes #393 Closes #391 Closes #402

The bubble menu can be modified to add more options. For now I've just added bold, italic and link options in it.

Nirajn2311 commented 5 months ago

When a text is turned into a link, could you change the popup to something like the one in the image below, so the user can edit or remove the link?

Is it fine if the popup came on selecting the text coz I'm not sure if I'll be able to get it working for hover(have to confirm this)

sidemt commented 5 months ago

Is it fine if the popup came on selecting the text

Yes, I think it's ok. It's better if we could keep the hover behavior so that authors can easily find it, but as long as we provide a way to edit/remove the link somehow, it's fine.

socket-security[bot] commented 5 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@floating-ui/react@0.26.9 Transitive: environment +10 6.52 MB atomiks, fezvrasta

View full report↗︎

Nirajn2311 commented 5 months ago

I got a menu to show up when you hover but the moment you move the cursor to the menu the damn thing keeps disappearing. I've been at it for 2 days now trying various methods, BubbleMenu(TipTap extension) and finally came to tippy.js (BubbleMenu uses this behind the scenes).

IT'S FINALLY WORKING

Nirajn2311 commented 5 months ago

@sidemt I've got the hover menu working for links so this PR is good for another review