search

freeCodeCamp / testable-projects-fcc

Test suite for freeCodeCamp's legacy Codepen-based Curriculum
BSD 3-Clause "New" or "Revised" License
176 stars 113 forks source link

Project will NOT pass Test #811

Closed moniquerenecoates closed 5 years ago

moniquerenecoates commented 5 years ago

Issue Description

We were to use template via link below to create our first TRIBUTE PAGE for FCC: https://codepen.io/freeCodeCamp/full/zNqgVx

However code created 4 - 5 errors OK, I fixed them. But then the page code created 10 MORE errors after that! I started reading them, and realized there were too many errors that were just NOT related to the page I was trying to create,, but that were more related to the ORIGINAL Tribute Page link & the code that was given to us from FreeCodeCamp.com to begin with.

Browser Information

Your Code / Link to Your Pen

moniquerenecoates commented 5 years ago

Link to my PEN: https://codepen.io/Moni-Rene/pen/XGrmLb

petercr commented 5 years ago

@moniquerenecoates I just took a look 👀 at your pen to see if there were any problems with the testing suite the program which runs the tests I was actually able to get your CodePen pen to pass all 10 tests, so they are definitely working.

Here's some hints, combine both <img> tags in #img-div into 1 tag and make sure to add an id="image" property in the combined img tag.

Secondly you closed the #img-div a little too early... if you move it's closing tag further down, then the page will pass all the tests.

Hope this helps, have a great day 😄 👍

Peter Cr

moniquerenecoates commented 5 years ago

Thank you Peter, I appreciate the help. I am not sure the folks at FCC really want me there. They are hacking my coding attempts and my Pixabay image links and putting stupid scary faces in instead. .

This was my first project and I was overwhelmed with the coding info I put into my system, so sorting it all out was EASIER completing a project without an FCC code link actually! LOL 😉

We'll see if we continue or not. Anyway, thank you again! I appreciate it -Monqiue

Monique Rene Coates

New England (RI)401-209-8498

On Tue, Feb 26, 2019 at 10:31 AM Peter Cruckshank notifications@github.com wrote:

@moniquerenecoates https://github.com/moniquerenecoates I just took a look 👀 at your pen to see if there were any problems with the testing suite the program which runs the tests I was actually able to get your CodePen pen to pass all 10 tests, so they are definitely working.

Here's some hints, combine both tags in #img-div into 1 tag and make sure to add an id="image" property in the combined img tag.

Secondly you closed the #img-div a little too early... if you move it's closing tag further down, then the page will pass all the tests.

Hope this helps, have a great day 😄 👍

Peter Cr

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/freeCodeCamp/testable-projects-fcc/issues/811#issuecomment-467484412, or mute the thread https://github.com/notifications/unsubscribe-auth/AVW8kGjBqBqoTf2f_2u9suCailDzc-Pkks5vRVM7gaJpZM4bQ3DE .

petercr commented 5 years ago

@moniquerenecoates I sorry if you feel like anyone at Free Code Camp would not want you there. The people are wonderful, and always promote diversity.

With regards to the Pixabay image not loading, that is due to the fact that CodePen is being served over https and Pixabay is trying to serve the image over http. You most likely need a free developer API key in order to use it overhttps`

Best of luck 😄 👍

moniquerenecoates commented 5 years ago

Hi Peter, I think we jumped to quickly, we are at peace with freecodecamp folks. They were just getting frustrated with me bugging them too much. We also got the page to work and pass the test! YAY! 😀 Along with the Pixabay image too !!

Thank you! Monique Rene Coates

New England (RI)401-209-8498

On Tue, Feb 26, 2019 at 7:39 PM Peter Cruckshank notifications@github.com wrote:

@moniquerenecoates https://github.com/moniquerenecoates I sorry if you feel like anyone at Free Code Camp would not want you there. The people are wonderful, and always promote diversity.

With regards to the Pixabay image not loading, that is due to the fact that CodePen is being served over https and Pixabay is trying to serve the image over http. You most likely need a free developer API key in order to use it over https`

Best of luck 😄 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/freeCodeCamp/testable-projects-fcc/issues/811#issuecomment-467674719, or mute the thread https://github.com/notifications/unsubscribe-auth/AVW8kJvdK6qQoRyht9aOriZNMY3Gwzr6ks5vRdO9gaJpZM4bQ3DE .