search

freeCodeCamp / wiki

freeCodeCamp's deprecated wiki articles
http://www.freecodecamp.com/wiki
281 stars 308 forks source link

Add intermediate solution to Algorithm-Roman-Numeral-Converter #1151

Closed mrthnmn closed 8 years ago

mrthnmn commented 8 years ago

A second (intermediate) solution has been added.

Rafase282 commented 8 years ago

Please add a section to our articles related to your solution.

mrthnmn commented 8 years ago

I'm afraid I'm not sure what you want. I thought I was editing the existing wiki article on the Roman Numeral Converter Algorithm challenge. Do you want a more-thorough explanation of the code I added or a completely new wiki article?

On Thu, Jun 16, 2016 at 12:18 PM, Rafael J. Rodriguez < notifications@github.com> wrote:

Please add a section to our articles related to your solution.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FreeCodeCamp/wiki/pull/1151#issuecomment-226536311, or mute the thread https://github.com/notifications/unsubscribe/AQKaMFz1fpkkEt55GlFjrDTruTymn_pPks5qMXdGgaJpZM4I3gRi .

Rafase282 commented 8 years ago

Please take a look here https://github.com/FreeCodeCamp/wiki/issues/1094

We have a template for solutions, and you adding a new one also requires a section with related links. I was asking to add it and use links form our wiki if possible. Sorry for not being clear before.

Rafase282 commented 8 years ago

Please try to fix the conflicts on your branch. Feel free to come to the wiki chat if you need help.

ghost commented 8 years ago

@mrthnmn, please resolve merge conflicts and implement suggestions :wink:

mrthnmn commented 8 years ago

I will do on Monday. I wasn't able to on Saturday because I was behind a corporate proxy.

On Sat, Jun 18, 2016 at 2:27 PM, Jonathan notifications@github.com wrote:

@mrthnmn https://github.com/mrthnmn, please resolve merge conflicts and implement suggestions 😉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FreeCodeCamp/wiki/pull/1151#issuecomment-226957672, or mute the thread https://github.com/notifications/unsubscribe/AQKaMHK8qlsdYSabI93g0N0J4BV1uwMcks5qNDiEgaJpZM4I3gRi .

alayek commented 8 years ago

@mrthnmn this branch has conflicts. You might need to rebase the branch.

mrthnmn commented 8 years ago

Attempt to resolve conflicts