search

freeCodeCampSF / FCCSF

View the website at https://freecodecampsf.github.io/FCCSF/
10 stars 11 forks source link

This here PR will, when approved, add Jackson's biographical info. #45

Closed abstractionjackson closed 4 years ago

abstractionjackson commented 4 years ago

here's my bio

abstractionjackson commented 4 years ago

The verb tense is meant to describe the branch commit after an approved PR. A more verbose message would read, "This commit, when merged, will add feature X." That's the style I was taught and have been using, and I think it makes grammatical sense. What are your thoughts?

On Mon, Oct 19, 2020 at 9:42 AM Julie Boberg notifications@github.com wrote:

@JulieBoberg requested changes on this pull request.

Please change commit message to what was done, not what you plan on doing. This makes it easier if anything has to be reverted in the future. The current commit message implies that you didn't add the third row. If it can't be fixed let me know, but I would like to keep our commit messages as communicative as possible. Thanks Jackson!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/freeCodeCampSF/FCCSF/pull/45#pullrequestreview-511956359, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALITPHVFWKLKEXLCM2TH5VLSLRT6PANCNFSM4SVJMIRA .

JulieBoberg commented 4 years ago

Please write out the more verbose version or write it out similar to 'Added a third row'. Whenever I see your commit messages they sound like issues that need to be solved, not what was actually fixed. Obviously it shouldn't be a problem for a basic thing like a bio card but in the future if you work on other features it could cause a miscommunication. Thank you.

JulieBoberg commented 4 years ago

Thanks Jackson!