stereoforever and The Room code artifacts

freeDSP / freeDSP-aurora

freeDSP ADAU1452 with 8 analog input, 8 analog outputs, S/P-DIF I/O, ADAT I/O, USB Audio Class2, WiFi, Bluetooth

Creative Commons Attribution Share Alike 4.0 International

176 stars 55 forks source link

stereoforever and The Room code artifacts #116

Closed exislow closed 2 years ago

exislow commented 2 years ago

hey @dspverden,

still a great job you are doing here. I have noticed that in the last commits code artifacts appeared, where you check against strings stereoforever and The Room to alter the behavior of the aurora board, for instance, see:

https://github.com/freeDSP/freeDSP-aurora/blob/5142f7cd48acabf1c630bbd7f1dddd0ec1198aa7/SOURCES/WEBAPP/ESP32/aurora/aurora.ino#L540

Is it possible, that this code handles only your private plugins? Have you committed it by accident?

dspverden commented 2 years ago

No, the reason is a little bit different: The plugin stereoforever will be released soon, it is in the final testing now, therefore, I decided to leave these checks in. Thus, I don't need a new release for the firmware for it. The plugin "The Room" is a custom plugin that I made. In order to keep the firmware compatible I left the check there. Regarding The Room please refer to www.hornsolutions.de and request the source codes there. The product is based on Aurora and falls under the license requirements of the CC license used by Aurora.

exislow commented 2 years ago

Thank you very much for the fast clarification. I am excited about upcomming plugin.