freeDSP / freeDSP-aurora

freeDSP ADAU1452 with 8 analog input, 8 analog outputs, S/P-DIF I/O, ADAT I/O, USB Audio Class2, WiFi, Bluetooth
Creative Commons Attribution Share Alike 4.0 International
176 stars 55 forks source link

8channel Plugin Gain and Phase Order #119

Closed xrtze closed 2 years ago

xrtze commented 2 years ago

In the dsp.html of the 8channels plugin, the order of the gains and phases does not correspond to the channel-id. Is this intended?

xrtze commented 2 years ago

Trying to build a custom plugin, I just can't make sense of the order, the phases and gains correspond to. Any hints?

dspverden commented 2 years ago

Did you read the wiki article about custom plugin creation?

I assume you are talking about the final dsp.html in the plugin folder. This was generated by sigma2aurora.py. Have a look at the source files there you can see (and after reading the wiki) the connection between the SigmaStudio project and the GUI provided as HTML file.

The reason that the order may look confusing is, that SigmaStudio exports register addresses for the parameters in a non-logical order. The script sigma2aurora.py is aware of this and manages this.

xrtze commented 2 years ago

Yes, i've read and followed the guide. I've also noticed the part in the sigma2aurora.py, which is correcting the ids. It does not seem to work though, because with the --gui option, the custom dsp.html is copied but the ids are not corrected. 6chpafir.zip

dspverden commented 2 years ago

Can you send me your source for dsp.html?

xrtze commented 2 years ago

In the above archive, under plugins/dsp.html. Since the sigma2aurora does not modify anything, it is literally the same file.

dspverden commented 2 years ago

No I mean the dsp.html that give with the --gui argument. It should look similar to the file you find in SOURCES/WEBAPP/plugins/8channels The file you provided specifies blocks that don't exist in the SigmaStudio file.

xrtze commented 2 years ago

which blocks exactly? i seem to have a wrong understanding of the naming convention then.

dspverden commented 2 years ago

eg delay block in channel 1. If you give the file you have provided in the archive to the --gui argument of sigma2aurora it will fail, because it has the wrong syntax. Compare it with the file I mentioned above

xrtze commented 2 years ago

Thanks for your help, rkv. and sorry for my stupid mistake! I did not realize, I was feeding sigma2aurora with the postprocessed dsp.html. now that i rebuilt everything based on the template + plugins from SOURCES/WEBAPP, everything works fine. I could just as well have beaten myself for 6 hours straight. Where shall I provide my custom plugin?