search

freeDSP / freeDSP-aurora

freeDSP ADAU1452 with 8 analog input, 8 analog outputs, S/P-DIF I/O, ADAT I/O, USB Audio Class2, WiFi, Bluetooth
Creative Commons Attribution Share Alike 4.0 International
181 stars 55 forks source link

aurora.ino:writeSettings: potential attempt to close non-opened file #18

Closed zas closed 4 years ago

zas commented 4 years ago

If fileSettings failed to open, trying to close it may lead to an error

https://github.com/freeDSP/freeDSP-aurora/blob/21276bfe22873ccbef2ed4d0ad9af257ecf8831c/SOURCES/WEBAPP/ESP32/aurora/aurora.ino#L509

zas commented 4 years ago

Same issue at https://github.com/freeDSP/freeDSP-aurora/blob/21276bfe22873ccbef2ed4d0ad9af257ecf8831c/SOURCES/WEBAPP/ESP32/aurora/aurora.ino#L885

zas commented 4 years ago

Related code isn't in develop branch anymore, closing.