Closed exislow closed 2 years ago
@exislow you have to base your PR on develop branch I think
Instead of changing the source code with logic expressions I would rather prefer to see the codes read from a config file, this will enable other IR remotes then Apple only.
Instead of changing the source code with logic expressions I would rather prefer to see the codes read from a config file, this will enable other IR remotes then Apple only.
I open the path to that in https://github.com/freeDSP/freeDSP-aurora/pull/97
Basically read IR value is passed to a function which returns a code for the button pressed, we can extend it to match more remotes more easily. It supports repeat too. Please comment on the PR itself
@exislow can you test if https://github.com/freeDSP/freeDSP-aurora/pull/97 works for you?
@exislow if you're ok, I think we can close this PR, as https://github.com/freeDSP/freeDSP-aurora/pull/97 includes this feature.
Sure.
But a proper code style refactoring should be done for sure.
To be able to adjust, e.g. volume more convenient remote button long press is now supported. If you press, for instance, UP for a long time, the volume will rise until you release the button on the IR.
Also code refactoring for
aurora.ino
was done to be able to maintaine and read the code better.