search

freeDSP / freeDSP-aurora

freeDSP ADAU1452 with 8 analog input, 8 analog outputs, S/P-DIF I/O, ADAT I/O, USB Audio Class2, WiFi, Bluetooth
Creative Commons Attribution Share Alike 4.0 International
176 stars 55 forks source link

IR long press support. #95

Closed exislow closed 2 years ago

exislow commented 2 years ago

To be able to adjust, e.g. volume more convenient remote button long press is now supported. If you press, for instance, UP for a long time, the volume will rise until you release the button on the IR.

Also code refactoring for aurora.ino was done to be able to maintaine and read the code better.

zas commented 2 years ago

@exislow you have to base your PR on develop branch I think

dspverden commented 2 years ago

Instead of changing the source code with logic expressions I would rather prefer to see the codes read from a config file, this will enable other IR remotes then Apple only.

zas commented 2 years ago

Instead of changing the source code with logic expressions I would rather prefer to see the codes read from a config file, this will enable other IR remotes then Apple only.

I open the path to that in https://github.com/freeDSP/freeDSP-aurora/pull/97

Basically read IR value is passed to a function which returns a code for the button pressed, we can extend it to match more remotes more easily. It supports repeat too. Please comment on the PR itself

zas commented 2 years ago

@exislow can you test if https://github.com/freeDSP/freeDSP-aurora/pull/97 works for you?

zas commented 2 years ago

@exislow if you're ok, I think we can close this PR, as https://github.com/freeDSP/freeDSP-aurora/pull/97 includes this feature.

exislow commented 2 years ago

Sure.

But a proper code style refactoring should be done for sure.