search

freebsd / crochet

Build FreeBSD images for RaspberryPi, BeagleBone, PandaBoard, and others.
BSD 2-Clause "Simplified" License
611 stars 187 forks source link

fix SOURCE_VERSION svn(lite)version being used, as well as sys/conf/newv... #105

Closed f-andrey closed 9 years ago

f-andrey commented 9 years ago

...ers.sh the fix would eliminate the multiple call external programs

Also, if possible, would like to make a global SOURCE_VERSION for reuse, (image name or else) Unfortunately I am not very well programmed in until it get over like so https://bitbucket.org/f_andrey/crochet-for-me/commits/1497d394bee5e5a9597caab8d0c5512b3f78f168

kientzle commented 9 years ago

You should not have /usr/bin or /usr/local/bin paths here (people might have these binaries in other directories).

Isn't svnversion much, much slower than 'svn info'? I haven't used it recently, but I thought it scanned the entire directory tree.

f-andrey commented 9 years ago

Yes slower. But it is important for a total duration of the process, but it shows whether the modified source code

# time sh -c 'svn info | grep Revision: | cut -c11-'
282105
0.009u 0.009s 0:00.01 0.0%      0+0k 0+0io 0pf+0w
# time svnliteversion /usr/src
282105M
0.472u 0.984s 0:05.07 28.5%     1235+170k 981+0io 1pf+0w
kientzle commented 9 years ago

Looks good. Thank you!