r255775 causes build world to break

[davecheney]

After revision r255774 the build fails with this error

creating osreldate.h from newvers.sh *\ [osreldate.h] Error code 1

bmake[3]: stopped in /root/crochet-freebsd/src/include 1 error

bmake[3]: stopped in /root/crochet-freebsd/src/include *\ [includes] Error code 2

bmake[2]: stopped in /root/crochet-freebsd/src/include 1 error

bmake[2]: stopped in /root/crochet-freebsd/src/include *\ [include.includes__D] Error code 2

Reading the PR the commit was addressing, it appears to have had the opposite effect

http://www.freebsd.org/cgi/query-pr.cgi?pr=160646&cat=misc

[kientzle]

+ian

Dave,

I've noticed this as well. I'm not sure it's directly related to r255775; I've managed to narrow it down to a block in newvers.sh that's checking for git stuff.

Are you setting FREEBSD_SRC in your Crochet configuration?

In my case, I have an SVN checkout of FreeBSD src in a subdirectory underneath a GIT checkout of Crochet and I think that's confusing the newvers.sh logic.

Tim

On Sep 23, 2013, at 12:43 AM, Dave Cheney notifications@github.com wrote:

After revision r255774 the build fails with this error

creating osreldate.h from newvers.sh *\ [osreldate.h] Error code 1

bmake[3]: stopped in /root/crochet-freebsd/src/include 1 error

bmake[3]: stopped in /root/crochet-freebsd/src/include *\ [includes] Error code 2

bmake[2]: stopped in /root/crochet-freebsd/src/include 1 error

bmake[2]: stopped in /root/crochet-freebsd/src/include *\ [include.includes__D] Error code 2

Reading the PR the commit was addressing, it appears to have had the opposite effect

http://www.freebsd.org/cgi/query-pr.cgi?pr=160646&cat=misc

— Reply to this email directly or view it on GitHub.

[kientzle]

Hmm, it looks like in addition to what I committed, we also need something like the patch I proposed in PR 174422. I'll attach an updated version. If this fixes your problem I'll get it commited.

Also, I'm sad to say it took me 3 tries to get the original stuff right, so sure you have r255775 + r255796 + r255807 before applying this.

-- Ian

On Mon, 2013-09-23 at 06:37 -0700, Tim Kientzle wrote:

+ian

Dave,

I've noticed this as well. I'm not sure it's directly related to r255775; I've managed to narrow it down to a block in newvers.sh that's checking for git stuff.

Are you setting FREEBSD_SRC in your Crochet configuration?

In my case, I have an SVN checkout of FreeBSD src in a subdirectory underneath a GIT checkout of Crochet and I think that's confusing the newvers.sh logic.

Tim

On Sep 23, 2013, at 12:43 AM, Dave Cheney notifications@github.com wrote:

After revision r255774 the build fails with this error

creating osreldate.h from newvers.sh *\ [osreldate.h] Error code 1

bmake[3]: stopped in /root/crochet-freebsd/src/include 1 error

bmake[3]: stopped in /root/crochet-freebsd/src/include *\ [includes] Error code 2

bmake[2]: stopped in /root/crochet-freebsd/src/include 1 error

bmake[2]: stopped in /root/crochet-freebsd/src/include *\ [include.includes__D] Error code 2

Reading the PR the commit was addressing, it appears to have had the opposite effect

http://www.freebsd.org/cgi/query-pr.cgi?pr=160646&cat=misc

— Reply to this email directly or view it on GitHub.

[davecheney]

Hi Tim,

Yup, I'm checking out the source to crotchet-freebsd/src, reverting to the revision 255774 builds as expected.

On 23 Sep 2013, at 23:37, Tim Kientzle notifications@github.com wrote:

+ian

Dave,

I've noticed this as well. I'm not sure it's directly related to r255775; I've managed to narrow it down to a block in newvers.sh that's checking for git stuff.

Are you setting FREEBSD_SRC in your Crochet configuration?

In my case, I have an SVN checkout of FreeBSD src in a subdirectory underneath a GIT checkout of Crochet and I think that's confusing the newvers.sh logic.

Tim

On Sep 23, 2013, at 12:43 AM, Dave Cheney notifications@github.com wrote:

After revision r255774 the build fails with this error

creating osreldate.h from newvers.sh *\ [osreldate.h] Error code 1

bmake[3]: stopped in /root/crochet-freebsd/src/include 1 error

bmake[3]: stopped in /root/crochet-freebsd/src/include *\ [includes] Error code 2

bmake[2]: stopped in /root/crochet-freebsd/src/include 1 error

bmake[2]: stopped in /root/crochet-freebsd/src/include *\ [include.includes__D] Error code 2

Reading the PR the commit was addressing, it appears to have had the opposite effect

http://www.freebsd.org/cgi/query-pr.cgi?pr=160646&cat=misc

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

[kientzle]

I believe this has been fixed in FreeBSD sources.