search

freebsd / crochet

Build FreeBSD images for RaspberryPi, BeagleBone, PandaBoard, and others.
BSD 2-Clause "Simplified" License
612 stars 188 forks source link

Chromebook #84

Closed teverett closed 10 years ago

teverett commented 10 years ago

Added Chromebook support Updated License Renamed readme.txt files formatted as markdown to readme.md Fixed hardcoded uboot source path for Wandboard to a parameter

kientzle commented 10 years ago

Nicely done! I commented a couple of minor changes that you might consider in the future, but I'm going to merge this now.

teverett commented 10 years ago

Thanks. I'll make those changes. I was also thinking of moving the include of gpt.sh into disk.sh rather than crochet.sh. That way, down the road, we can move the mbr stuff into mbr.sh and include that into disk.sh too.

On Sat, Aug 23, 2014 at 9:59 AM, Tim Kientzle notifications@github.com wrote:

Merged #84 https://github.com/kientzle/crochet-freebsd/pull/84.

— Reply to this email directly or view it on GitHub https://github.com/kientzle/crochet-freebsd/pull/84#event-156408805.

A better world shall emerge based on faith and understanding - Douglas MacArthur

kientzle commented 10 years ago

On Aug 23, 2014, at 9:01 AM, Tom Everett notifications@github.com wrote:

Thanks. I'll make those changes. I was also thinking of moving the include of gpt.sh into disk.sh rather than crochet.sh.

Personally, I'd like to avoid multi-level inclusions like this.

Keeping all the includes directly in crochet.sh makes it a little easier for people to learn the code, I think.

That way, down the road, we can move the mbr stuff into mbr.sh and include that into disk.sh too.

Migrating MBR support into mbr.sh (or maybe disk_mbr.sh?) makes a lot of sense.

Tim

On Sat, Aug 23, 2014 at 9:59 AM, Tim Kientzle notifications@github.com wrote:

Merged #84 https://github.com/kientzle/crochet-freebsd/pull/84.

— Reply to this email directly or view it on GitHub https://github.com/kientzle/crochet-freebsd/pull/84#event-156408805.

A better world shall emerge based on faith and understanding - Douglas MacArthur — Reply to this email directly or view it on GitHub.