search

freebsd / drm-kmod-firmware

KMS firmware components for graphics/kms-firmware port
Other
22 stars 17 forks source link

amdgpu: reintroduce green_sardine and sienna_cichlid firmware #23

Closed xmhd closed 2 years ago

xmhd commented 2 years ago

This PR addresses #21 Also addresses https://github.com/freebsd/drm-kmod/issues/155

This firmware was previously included, but was removed due to 'module names being too long to be processed by kldxref (see: 0382c95abdcd14d14696628c61f6354553fc70a8)'. This has apparently been fixed in 13.1 + 14.0, and the firmware is required for Cezanne APU's to work on 5.10 (previously worked on 5.7 with Renoir firmware as they are closely related).

I believe the next missing piece of the puzzle is adding the relevant bits to the Makefile in the gpu-firmware-kmod port.

evadot commented 2 years ago

That will still fails on < 13.1 so we need to exclude them there.

xmhd commented 2 years ago

That will still fails on < 13.1 so we need to exclude them there.

I'll add this and update the PR.

edit: OSMAJOR or OSVERSION for the version check?

asas1asas200 commented 2 years ago

Does it need to add green_sardine*.bin files in amdgpukmsfw-files directory? I have tried this PR on my FreeBSD 14.0-CURRENT but failed when make green_sardine_asd.bin.

The error message is below:

make[2]: don't know how to make /usr/home/zeng/Desktop/drm-kmod-firmware/amdgpukmsfw/green_sardine_asd/../../amdgpukmsfw-files/green_sardine_asd.bin. Stop

So I think the *.bin files about green_sardine should be put in amdgpukmsfw-files, and it can be found in Linux Kernel firmware(but I'm not sure if it existed in v5.10).

xmhd commented 2 years ago

Does it need to add green_sardine*.bin files in amdgpukmsfw-files directory? I have tried this PR on my FreeBSD 14.0-CURRENT but failed when make green_sardine_asd.bin.

The error message is below:

make[2]: don't know how to make /usr/home/zeng/Desktop/drm-kmod-firmware/amdgpukmsfw/green_sardine_asd/../../amdgpukmsfw-files/green_sardine_asd.bin. Stop

So I think the *.bin files about green_sardine should be put in amdgpukmsfw-files, and it can be found in Linux Kernel firmware(but I'm not sure if it existed in v5.10).

Good catch - this will indeed need done.

I'm traveling tomorrow so probably not able to work on this, but I'll do it afterwards.

evadot commented 2 years ago

Not needed anymore.