search

freebsd / drm-kmod

drm driver for FreeBSD
155 stars 69 forks source link

5.15-lts: Update to v5.15.148 #285

Closed wulf7 closed 4 months ago

wulf7 commented 7 months ago

It includes:

Not very extensive tested. Tests conducted (separately):

evadot commented 7 months ago

I'm not a fan or both the ubuntu patches and the revert to GPL dmabuf code. I think that the first step is to update to the latest version of 5.15-lts. For the ubuntu patches are those issue fixed in 6.1/6.6 ? For dmabuf if there is still problems on rare configurations, I'd like to know more about those. Keep in mind that the goal is to have drm back in base and so GPL code isn't a solution.

wulf7 commented 7 months ago

I'm not a fan or both the ubuntu patches and the revert to GPL dmabuf code.

It is a leaf branch. I have no intentions of putting this into master. I think I fixed FPU issues in CURRENT and hope to MFC 6.1 KPI changes to 14-STABLE in next 2 weeks. In that case 5.15 will became obsolete as soon as package building cluster switches to 14.1

For the ubuntu patches are those issue fixed in 6.1/6.6 ?

Yes, all issues known to me were fixed upstream circa 5.17-5.18

For dmabuf if there is still problems on rare configurations, I'd like to know more about those. Keep in mind that the goal is to have drm back in base and so GPL code isn't a solution.

At work I have got couple of crash reports right after fixing of dma-buf memory leak. I was not able to reproduce them locally on almost identical hardware and software and switching to GPL code fixed crashes for users. Never dig into the bug later. There seems that other users faced with the bug also (along wih external display issue): https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274770

evadot commented 7 months ago

I'm not a fan or both the ubuntu patches and the revert to GPL dmabuf code.

It is a leaf branch. I have no intentions of putting this into master. I think I fixed FPU issues in CURRENT and hope to MFC 6.1 KPI changes to 14-STABLE in next 2 weeks. In that case 5.15 will became obsolete as soon as package building cluster switches to 14.1

Do I understand correctly that the revert to GPL dmabuf isn't needed for >5.15 ?

For the ubuntu patches are those issue fixed in 6.1/6.6 ?

Yes, all issues known to me were fixed upstream circa 5.17-5.18

I really think that we should follow Linux mainline.

For dmabuf if there is still problems on rare configurations, I'd like to know more about those. Keep in mind that the goal is to have drm back in base and so GPL code isn't a solution.

At work I have got couple of crash reports right after fixing of dma-buf memory leak. I was not able to reproduce them locally on almost identical hardware and software and switching to GPL code fixed crashes for users. Never dig into the bug later. There seems that other users faced with the bug also (along wih external display issue): https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274770

Without a good known reproducer I don't think it's wise to create a divergence between our drm branches.

evadot commented 4 months ago

Is this still relevant ?

wulf7 commented 4 months ago

All external display issues were fixed in 6.1. Also I tried to sync RCU usage in dma-buf with Linux in 6.1 and I hope that dma-buf instability gone away too. But I have no means to test it. So upgrade to FBSD 14.1+drm_kmod 6.1 is a better way too go further.