freebsd / iocage

A FreeBSD jail manager
Other
19 stars 8 forks source link

Remove dependency on six #13

Closed bravesirrobin81 closed 2 months ago

bravesirrobin81 commented 2 months ago

I noticed that the Python 3.11 iocage-devel package has a missing dependency onsix. Given it's only used in one place, and for compatibility with Python 2 which is no longer supported, remove it.

Make sure to follow and check these boxes before submitting a PR! Thank you.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9724386434

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
iocage_lib/utils.py 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Files with Coverage Reduction New Missed Lines %
iocage_lib/release.py 1 0.0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9566853401: -0.4%
Covered Lines: 798
Relevant Lines: 7755

💛 - Coveralls
arrowd commented 2 months ago

@dgeo The PR makes sense, may I merge it?

dgeo commented 2 months ago

@arrowd of course you may, I can't check it now but feel free !