search

freebsd / kyua

Port/Package build and test system
https://github.com/freebsd/kyua/wiki
BSD 3-Clause "New" or "Revised" License
149 stars 42 forks source link

fixes a zero-length format string warning (gcc-4.9 confirmed) #130

Closed namore closed 8 years ago

namore commented 10 years ago

The warning causes the build of kyua to fail due to -Werror being set:

$ make
(...)
testers/atf_helpers.c: In function ‘atfu_print_config_head’:
testers/atf_helpers.c:169:9: error: zero-length gnu_printf format string [-Werror=format-zero-length]
         atf_utils_create_file(name, "");
         ^
cc1: all warnings being treated as errors
Makefile:6029: recipe for target 'testers/testers_atf_helpers-atf_helpers.o' failed
make[1]: *** [testers/testers_atf_helpers-atf_helpers.o] Error 1
make[1]: Leaving directory '/home/namor/clones/kyua_namore'
Makefile:3448: recipe for target 'all' failed
make: *** [all] Error 2
$ gcc --version
gcc (Debian 4.9.1-16) 4.9.1
(...)
jmmv commented 10 years ago

Thanks for the fix.

If you want me to be able to accept your pull request, please go to:

https://github.com/jmmv/kyua/wiki/Contributing

and follow the instructions and guidelines in there.

jmmv commented 8 years ago

This is now obsolete given that HEAD has no more .c files.