freebsd / kyua

Port/Package build and test system
https://github.com/freebsd/kyua/wiki
BSD 3-Clause "New" or "Revised" License
149 stars 42 forks source link

kyua tests implicitly require tmpfs #135

Open ngie-eign opened 9 years ago

ngie-eign commented 9 years ago

I was running the new kyua tests and I noticed that some of the tests were failing with asserts. I did some more digging and the failures are caused by tmpfs not being compiled into my kernel.

I haven't read through the release notes yet, but it would be nice if this requirement was a bit detected, and the testcases skipped potentially if tmpfs couldn't be mounted..

rodrigc commented 9 years ago

tmpfs can be detected by doing: lsvfs It is also possible to do: kldload tmpfs lsvfs

and see if tmpfs is available after trying to load the kernel module.

jmmv commented 8 years ago

At this point only the utils/fs/operations_test:free_disk_space__ok__real test needs tmpfs, (The other tests using tmpfs are tests for the mount_tmpfs auxiliary function itself.)

I think I'd rather make this test not need tmpfs so that we can remove the complex logic to mount a tmpfs file system. Poking the list of available file systems via sysctl or /proc or whatever is needed depending on the OS is not something I'd like to do.