search

freebsd / kyua

Port/Package build and test system
https://github.com/freebsd/kyua/wiki
BSD 3-Clause "New" or "Revised" License
149 stars 42 forks source link

Upgrade Ubuntu image from Trusty to Xenial #195

Closed ngie-eign closed 5 years ago

ngie-eign commented 5 years ago

This change requires #194 and #197 in order for all Travis CI targets to complete cleanly, but it can be merged separately in order to make forward progress, as Travis is currently completely broken.

ngie-eign commented 5 years ago

@jmmv: here's a link to the testing that I did: https://travis-ci.org/ngie-eign/kyua/builds/509534663 . I will be working on fixing the issues with make apidocs not passing (it's due to a number of undocumented APIs and parameters).

If you copy the snapshots to your bintray account, I will reference them in the commit, or you can adjust the code after it's been pulled 🤷‍♀️.

ngie-eign commented 5 years ago

@jmmv: ping? This change needs to go in in order for things to pass [more] on master (it's very red :/..).

jmmv commented 5 years ago

Oh nice. The matrix inclusion is so much easier to read...

jmmv commented 5 years ago

Commented out code is bound to rot, so I'd have removed all those i386 entries and replaced the whole thing with something like:

TODO(...): Add i386 tests. They were removed because the necessary libraries are not available in Xenial, so we need to figure out an alternative.

But anyway, not going to delay merging on this.

ngie-eign commented 5 years ago

Commented out code is bound to rot, so I'd have removed all those i386 entries and replaced the whole thing with something like:

TODO(...): Add i386 tests. They were removed because the necessary libraries are not available in Xenial, so we need to figure out an alternative.

But anyway, not going to delay merging on this.

I'll delete this when I get osx support to work.