search

freebsd / kyua

Port/Package build and test system
https://github.com/freebsd/kyua/wiki
BSD 3-Clause "New" or "Revised" License
149 stars 42 forks source link

Eliminate `UTILS_UNUSED_PARAM(..)` macro #198

Closed ngie-eign closed 5 years ago

ngie-eign commented 5 years ago

Unlike C, C++ has the ability to omit parameter names in implemented interfaces when the parameter is unused, aka "unnamed parameters"

This change does the following:

  1. Mechanically replace UTILS_UNUSED_PARAM(x) with /* x */.
  2. Removes all doxygen directives that reference unused_*.
  3. Removes the m4 macro that looks for __attribute__((unused)).

Signed-off-by: Enji Cooper yaneurabeya@gmail.com

ngie-eign commented 5 years ago

@jmmv: this came about as a subthread when reviewing #197. It probably won't pass Travis because Travis is broken on master. #195 would make this change a bit more green by at least checking to make sure things compile on Travis.

ngie-eign commented 5 years ago

@jmmv: ready! It needs some more fix up in order to pass make apidocs, but I will resolve that as part of #197.

ngie-eign commented 5 years ago

@jmmv: ping?

ngie-eign commented 5 years ago

This was merged as part of #197, so I'm closing this PR.

jmmv commented 5 years ago

Was it? The #197 diff doesn't mention UTILS_UNUSED_PARAM at all...

ngie-eign commented 5 years ago

Was it? The #197 diff doesn't mention UTILS_UNUSED_PARAM at all...

It was based on that branch. Sorry about the confusion >_>..

jmmv commented 5 years ago

I don't understand... even if that commit was on top of another unmerged branch, GitHub should have showed the diff against the master branch (and thus have showed the two changes). Also, looking at head, I still see the macro. So... this PR needs to be revived? Is that what you meant?

ngie-eign commented 5 years ago

I don't understand... even if that commit was on top of another unmerged branch, GitHub should have showed the diff against the master branch (and thus have showed the two changes). Also, looking at head, I still see the macro. So... this PR needs to be revived? Is that what you meant?

Oh wait! I split them up! Shoot... yeah, I'll revive the branch in a sec.

ngie-eign commented 5 years ago

Ugh. Need to use another name. GitHub isn't letting me reopen this because I prematurely deleted the branch :(.

ngie-eign commented 5 years ago

Ok, opened a new PR: #201. I'm waiting for it to complete.