Jail upgrade failures

[grahamperrin]

Prerequisites

• ☑ Have you checked for an existing issue describing your problem?
• ☑ Are you running the latest version?
• ☑ Is your ports tree recent?
• ☑ Is your FreeBSD Host on a supported release?

Describe the bug

Repeated misbehaviour when attempting to upgrade an up-to-date jail.

How to reproduce

1. Jail named thirteen, 13.1-RELEASE-p7
2. poudriere jail -u -j thirteen
3. poudriere jail -u -j thirteen -t 13.2-RELEASE
4. observe the line quoted below, repeatedly
5. files that (I believe) should be in FreeBSD 13.2-RELEASE are reportedly no longer existent.

/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory

Expected behaviour

Preparations for upgrade without messages about files/.gz and suspiciously non-existent files.

Environment

• Host OS 13.2-RELEASE
• Jail OS 13.1-RELEASE-p7
• poudriere-devel-3.3.99.20220831
• Ports branch and revision: not relevant

Additional context

root@fuji:~ # poudriere jail -i -j thirteen
Jail name:         thirteen
Jail version:      13.1-RELEASE-p7
Jail arch:         amd64
Jail method:       http
Jail mount:        /usr/local/poudriere/jails/thirteen
Jail fs:           fuji/poudriere/jails/thirteen
Jail updated:      2023-05-30 19:30:47
Jail pkgbase:      disabled
root@fuji:~ # poudriere jail -u -j thirteen
[00:00:00] Upgrading using http
Looking up update.FreeBSD.org mirrors... 2 mirrors found.
Fetching metadata signature for 13.1-RELEASE from update2.freebsd.org... done.
Fetching metadata index... done.
Inspecting system... done.
Preparing to download files... done.
The following files are affected by updates. No changes have
been downloaded, however, because the files have been modified
locally:
/etc/mtree/BSD.usr.dist
/var/db/etcupdate/current/etc/mtree/BSD.usr.dist
/var/db/etcupdate/log
/var/db/mergemaster.mtree

No updates needed to update system to 13.1-RELEASE-p7.
13.1-RELEASE-p7
[00:00:57] Recording filesystem state for clean... done
root@fuji:~ # poudriere jail -u -j thirteen -t 13.2-RELEASE
[00:00:00] Upgrading using http
Looking up update.FreeBSD.org mirrors... 2 mirrors found.
Fetching metadata signature for 13.1-RELEASE from update1.freebsd.org... done.
Fetching metadata index... done.
Fetching 1 metadata patches. done.
Applying metadata patches... done.
Fetching 1 metadata files... done.
Inspecting system... done.

The following components of FreeBSD seem to be installed:
kernel/generic src/src world/base world/lib32

The following components of FreeBSD do not seem to be installed:
kernel/generic-dbg world/base-dbg world/lib32-dbg

Fetching metadata signature for 13.2-RELEASE from update1.freebsd.org... done.
Fetching metadata index... done.
Fetching 1 metadata patches. done.
Applying metadata patches... done.
Fetching 1 metadata files... done.
Inspecting system... done.
Fetching files from 13.1-RELEASE for merging... done.
Preparing to download files... done.
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
/tmp/poudriere.aIxsKEM4/freebsd-update.TlEQ01MP: cannot open files/.gz: No such file or directory
Attempting to automatically merge changes in files... done.

The following file will be removed, as it no longer exists in
FreeBSD 13.2-RELEASE: /etc/defaults/devfs.rules
Does this look reasonable (y/n)? y

The following file will be removed, as it no longer exists in
FreeBSD 13.2-RELEASE: /etc/defaults/rc.conf
Does this look reasonable (y/n)? n
[00:11:52] Error: Fail to upgrade system
root@fuji:~ #