poudriere jail -P only works with subversion - Githubissues

freebsd / poudriere

Port/Package build and test system

https://github.com/freebsd/poudriere/wiki

BSD 2-Clause "Simplified" License

379 stars 161 forks source link

poudriere jail -P only works with subversion #1057

Open igalic opened 1 year ago

igalic commented 1 year ago

Prerequisites

[x] Have you checked for an existing issue describing your problem?
[x] Are you running the latest version?
[x] Is your ports tree recent?
[x] Is your FreeBSD Host on a supported release?

Describe the bug

Despite appearances, trying to patch the tree with -P, doesn't work when updating -u:

root@builder:~ # poudriere jail -u -x -P /root/776-with-typo-in-path.patch -j 14-current-armv7
[00:00:00] Error: No such patch
root@builder:~ #

poudriere checks for the validity of the patch, but it doesn't apply it.

How to reproduce

create a jail:

poudriere jail -c -j 14-current-aarch64 -x -a arm64.aarch64 -B -b -m git+https -v main -K "GENERIC"

append ASUS_AC1300 to the jail's kernel file
fetch my patch to verify this KERNCONF now builds: https://patch-diff.githubusercontent.com/raw/freebsd/freebsd-src/pull/776.patch

try to update the jail to prove that:

poudriere jail -u -x -P /root/776.patch -j 14-current-armv7

it fails to build, ergo, the patch didn't apply

Expected behavior

I would expect the patch to be applied (after updating the tree).

Environment

Host OS: FreeBSD 13-STABLE amd64
Jail OS: 14-CURRENT armv7
Poudriere Version: poudriere-git-3.3.99.20220831

igalic commented 1 year ago

looking at the code, -P is only supported for subversion?

Why?