search

freebsd / poudriere

Port/Package build and test system
https://github.com/freebsd/poudriere/wiki
BSD 2-Clause "Simplified" License
379 stars 161 forks source link

allow native compliation for armv6 on armv7 arch as CPU-s are backward compatible #1063

Closed samm-git closed 6 months ago

samm-git commented 11 months ago

poudriere asks for QEMU binary if running on armv7 host and target is armv6. As ARMv7 is backward compatible with v6 it is not realy needed. This patch relaxes this check

samm-git commented 6 months ago

Ping :)

igalic commented 6 months ago

@samm-git can you fix the title of commit message / pull request?

samm-git commented 6 months ago

@igalic done, i hope its better now

igalic commented 6 months ago

still needs fixing in the commit message:

git commit --amend
git push -f $your-origin patch-1
samm-git commented 6 months ago

@igalic done, thanks. Also rebased to the upstream

bapt commented 6 months ago

I don't like adding this "hack" to poudriere, kern.supported_arch is supposed to say armv6 if it does support it, imho we should fix the kernel to expose it. I need to think more about it.

samm-git commented 6 months ago

@bapt it would be nice for the kernel to expose it, agree, but not sure that it's realistic, given the current state of the armv6 support. I am using this hack to build rpi1 packages and at least for the packages I am using it works reasonably well, much better compared to armv6/qemu on amd64 option IMO.