Fix #1001: `set -o noglob` around wildcard `case` loops

freebsd / poudriere

Port/Package build and test system

https://github.com/freebsd/poudriere/wiki

BSD 2-Clause "Simplified" License

379 stars 161 forks source link

Fix #1001: `set -o noglob` around wildcard `case` loops #1065

Closed overhacked closed 9 months ago

overhacked commented 11 months ago

When a variable that contains glob wildcards is evaluated in a for statement, the glob characters are expanded in the current directory. The intent of these loops is that the glob characters be passed to the case statement as patterns to match against.

Previously fixed for TMPFS_BLACKLIST by #987.
This PR fixes #1001, the issue for PACKAGE_FETCH_BLACKLIST, PRIORITY_BOOST, PACKAGE_FETCH_WHITELIST, and ALLOW_NETWORKING_PACKAGES.

overhacked commented 11 months ago

Only about a year overdue. Thanks for your patience!