search

freebsd / poudriere

Port/Package build and test system
https://github.com/freebsd/poudriere/wiki
BSD 2-Clause "Simplified" License
388 stars 161 forks source link

Update bootstrap@5.3.3 and DataTables@2.0.2 #1134

Open fel1x-developer opened 6 months ago

fel1x-developer commented 6 months ago

Screenshot 2024-03-12 141915 Screenshot 2024-03-12 141948 Screenshot 2024-03-12 142002 Screenshot 2024-03-12 142011 Screenshot 2024-03-12 142024 Screenshot 2024-03-12 142033 Screenshot 2024-03-12 142041

bdrewery commented 5 months ago

I want to merge this but the last commit is hard to review and has unrelated changes in it. Can you either remove the last commit or split it into coherent independent commits? "Use try/catch", "Split into several files". I don't like the splitting of the file as it makes review/history hard.

fel1x-developer commented 5 months ago

I want to merge this but the last commit is hard to review and has unrelated changes in it. Can you either remove the last commit or split it into coherent independent commits? "Use try/catch", "Split into several files". I don't like the splitting of the file as it makes review/history hard.

I was working on other PR which aims for splitting js files using modules, and I made a mistake to add new modules files in this review. I removed them from the last commit.

fel1x-developer commented 3 months ago

I'll introduce these changes gradually