search

freebsd / poudriere

Port/Package build and test system
https://github.com/freebsd/poudriere/wiki
BSD 2-Clause "Simplified" License
388 stars 161 forks source link

Makefile.am: Move optimization level to AM_CFLAGS #1147

Closed fel1x-developer closed 2 months ago

fel1x-developer commented 5 months ago

Defining CFLAGS in Makefile.am is not recommended and generates a warning in autoreconf stage. Since CFLAGS is a user variable, it should not be directly modified by autoreconf.

Warning generated by ./autogen.sh

Makefile.am:12: warning: 'CFLAGS' is a user variable, you should not override it;
Makefile.am:12: use 'AM_CFLAGS' instead

This fixes commit 52fff5ef4bcf8fa67dc90819494b9a43b9131122

fel1x-developer commented 3 months ago

Can this PR be comitted to the main branch?

bdrewery commented 2 months ago

This causes -01 to not be used; -00 is used instead. -01 was added intentionally.

fel1x-developer commented 2 months ago

Figured out that optimization level cannot be set through AM_CFLAGS. I'm withdrawing this PR.