logclean ignores dry run option - Githubissues

freebsd / poudriere

Port/Package build and test system

https://github.com/freebsd/poudriere/wiki

BSD 2-Clause "Simplified" License

396 stars 164 forks source link

logclean ignores dry run option #1186

Closed michael-o closed 1 week ago

michael-o commented 1 week ago

Prerequisites

[X] Have you checked for an existing issue describing your problem?
[X] Are you running the latest version?
[X] Is your ports tree recent?
[X] Is your FreeBSD Host on a supported release?

Describe the bug

Trying to run logclean with dry-run still offers me to delete files:

poudriere logclean  30 -n  -j 133-release-amd64 -p default -z common
133-release-amd64-default-indocs/2024-10-13T13:20:29
[00:00:00] Removing these 169 builds older than 30 days in /var/poudriere/data/logs/bulk (filtered) will free: 3.39 GiB
[00:00:00] Proceed? [y/N] y
[00:00:04] Removing files...^C[00:00:05] [23908] Signal INT caught

Even if I add -y it is still interactive.

Expected behavior

Nothing should be removed and I should not be asked interactive whether I want to continue. It should just display what can be deleted.

Environment

Host OS: 13.4-STABLE cc07d914b amd64
Poudriere Version [e.g. 3.3.1 or git hash or port version]: poudriere-git-3.4.99.20240811
Ports branch and revision [e.g. 2020Q3 r550754]: main

michael-o commented 1 week ago

My bad....