search

freebsd / poudriere

Port/Package build and test system
https://github.com/freebsd/poudriere/wiki
BSD 2-Clause "Simplified" License
391 stars 161 forks source link

FLAVORS and DEPENDS_ARGS support is insane #492

Open bdrewery opened 7 years ago

bdrewery commented 7 years ago

The code for this is really crazy from #483. At the very least it needs a design doc.

The feature is trivial to implement in a naive way, but very difficult to support parallel dependency lookups in an efficient way while both supporting bulk -a and bulk list.

There's definitely room for improvement here. Another queue or 2 could likely remove the "metadata" hack that was added.

488 makes it safer to refactor this code. It could in theory wait for _DEPENDSARGS support to come out but we'll likely keep it for building older ports trees.

bdrewery commented 1 year ago

6ce2d0b58733ea86df26668a98e0ad356c1a6318 dropped DEPENDS_ARGS support.