freebsd / poudriere

Port/Package build and test system
https://github.com/freebsd/poudriere/wiki
BSD 2-Clause "Simplified" License
393 stars 162 forks source link

Documented and actual default methods (jail and ports) don't match #803

Open neirbowj opened 3 years ago

neirbowj commented 3 years ago

The documented default jail method is "http". The actual default jail method is"ftp".

~The documented default ports method is "svn+https". The actual default ports method is "portsnap".~

swills commented 3 years ago

I think you're looking at older hashes, tho for the ports one that's only for update. I missed that in this:

https://github.com/freebsd/poudriere/commit/ff95dd3bcaef53f5e520e7f4837063ef4cd70bcd

I'll send a pull request.

neirbowj commented 3 years ago

f4bf593 is the latest commit on master from 3 days ago. I was trying to pin the links in the description to a recent point in time so the line number references wouldn't break in the future.

You are correct that creating a ports tree does use "svn+https". I found the jail problem first and did a quick scan of the source code to see if it looked like ports was affected too. It looks like creating a ports tree works per the man page.

As for jail, on 12.2-RELEASE with poudriere 3.3.6:

$ sudo poudriere jail -c -j test -v 12.2-RELEASE
[00:00:00] Creating test fs at /srv/poudriere/jails/test... done
[00:00:00] Using pre-distributed MANIFEST for FreeBSD 12.2-RELEASE amd64
[00:00:00] Fetching base for FreeBSD 12.2-RELEASE amd64
/srv/poudriere/jails/test/fromftp/base.txz             174 MB   63 MBps    03s
[00:00:04] Extracting base... done
[00:00:26] Fetching src for FreeBSD 12.2-RELEASE amd64
/srv/poudriere/jails/test/fromftp/src.txz              163 MB   69 MBps    02s
[00:00:30] Extracting src... done
[00:00:58] Fetching lib32 for FreeBSD 12.2-RELEASE amd64
/srv/poudriere/jails/test/fromftp/lib32.txz             63 MB   53 MBps    01s
[00:01:00] Extracting lib32... done
[00:01:08] Cleaning up... done
[00:01:08] Recording filesystem state for clean... done
[00:01:08] Upgrading using ftp
/etc/resolv.conf -> /srv/poudriere/jails/test/etc/resolv.conf
Looking up update.FreeBSD.org mirrors... 3 mirrors found.
Fetching public key from update1.freebsd.org... done.
Fetching metadata signature for 12.2-RELEASE from update1.freebsd.org... done.
Fetching metadata index... done.
Fetching 1 metadata files... done.
Inspecting system... done.
Preparing to download files... done.

No updates needed to update system to 12.2-RELEASE-p0.
test-default: removed
test-default-n: removed
12.2-RELEASE
[00:01:09] Recording filesystem state for clean... done
[00:01:09] Jail test 12.2-RELEASE amd64 is ready to be used
$ poudriere jail -l | grep test
test     12.2-RELEASE     amd64 ftp    2020-11-16 16:29:57 /srv/poudriere/jails/test
$ man poudriere-jail | grep -A1 default:
     -m method    Specifies which method to use to create the jail.  (default:
                  http)
grahamperrin commented 3 years ago

With poudriere-devel-3.3.99.20210720 the default methods appear to be: